Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for primary-replica connections #238

Merged
merged 8 commits into from Oct 29, 2021
Merged

Add support for primary-replica connections #238

merged 8 commits into from Oct 29, 2021

Conversation

Fs02
Copy link
Member

@Fs02 Fs02 commented Oct 25, 2021 •
edited

Issue: #226

@codecov
Copy link

codecov bot commented Oct 25, 2021 •
edited

Codecov Report

Merging #238 (b042431) into master (ecb6895) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #238   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3950      3958    +8     
=========================================
+ Hits          3950      3958    +8
Impacted Files Coverage Δ
migrator/migrator.go 100.00% <100.00%> (ø)
query.go 100.00% <100.00%> (ø)
repository.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb6895...b042431. Read the comment docs.

@Fs02 Fs02 changed the title Add UsePrimary query option Add support for primary-replica switching Oct 25, 2021
@Fs02 Fs02 changed the title Add support for primary-replica switching Add support for primary-replica connections Oct 27, 2021
@Fs02 Fs02 marked this pull request as ready for review October 27, 2021 18:52
@Fs02 Fs02 requested a review from lafriks October 27, 2021 18:54
lafriks
lafriks approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lafriks lafriks added the enhancement New feature or request label Oct 28, 2021
@Fs02 Fs02 merged commit e6a16a9 into master Oct 29, 2021
@Fs02 Fs02 deleted the primary-replica branch October 29, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Fs02 @lafriks