Add option to specify addtional filters for joins #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 56 56
Lines 3949 3950 +1
=========================================
+ Hits 3949 3950 +1
Continue to review full report at Codecov.
|
|
Does it look ok and I can move forward with sql part of this? |
yes, this is make sense, please go ahead |
|
Can be reviewed now |
Fs02
reviewed
Oct 20, 2021
|
Could you also tag when merged so I can update go-rel/sql PR |
how about using master first, and tag when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to specify additional conditions for query joins (for example to specify to join only not deleted records). Only workaround for this is to use
Joinfthat's not too nice to use as it won't provide a way to do per-adapter field escaping etc.I added filter as optional last parameter and as side effect of this is that you can provide multiple filters that will be converted to
Andfilter as the result.Still need to implement changes in sql, so currently marking this as WIP