Remove OpenTelemetry metrics for now #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
force-pushed
the
fix/remove-metrics-for-now
branch
from
9434646
to
a7ead1c
Compare
|
I think you should also update go.mod/go.sum, with |
vmihailenco
force-pushed
the
fix/remove-metrics-for-now
branch
from
a7ead1c
to
84b0ed0
Compare
|
@pierrre done, thanks |
monkey92t
approved these changes
Jun 30, 2021
|
Do we need to release a new version? |
|
@monkey92t yes, I think so. Could you tag one please? |
|
@vmihailenco OK, let me do it |
|
Do you plan to tag it today ? |
|
@pierrre I have created v8.11.0 version, I forgot to modify CHANGELOG.md, I will add it later. |
|
Thank you, it works ! |
zhenqianz
pushed a commit
to kumparan/redsync
that referenced
this pull request
Jun 29, 2022
zhenqianz
added a commit
to kumparan/redsync
that referenced
this pull request
Jun 29, 2022
bump: goredis version redis/go-redis#1805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1534
Removing metrics for now since they should use a ValueRecorder that records operation durations (if I remember Otel terms correctly)...