xgroup/xadd/xtrim supports new options #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XGROUP CREATECONSUMER XTRIM MINID LIMIT XADD NOMKSTREAM MINID LIMIT Signed-off-by: monkey <golang@88.com>
vmihailenco
reviewed
Jun 9, 2021
| Approx bool | ||
| Limit int64 | ||
| ID string | ||
| Values interface{} | ||
| } |
There was a problem hiding this comment.
Perhaps group MaxLen, MinID, and Approx:
MaxLen int64
MinID string
// Approx causes MaxLen and MinID to use "~" matcher (instead of "=").
Approx bool
vmihailenco
approved these changes
Jun 9, 2021
Signed-off-by: monkey92t <golang@88.com>
|
This fixes #1605 if I'm not wrong. |
monkey92t
added a commit
that referenced
this pull request
Jun 28, 2021
* Remove OpenTelemetry from the code (but leave redisotel as is) (#1782) * Add XAutoClaim command (#1780) * fix typo (#1788) * xgroup/xadd/xtrim supports new options (#1787) * support cmd option XGROUP CREATECONSUMER XTRIM MINID LIMIT XADD NOMKSTREAM MINID LIMIT Signed-off-by: monkey <golang@88.com> * add XAddArgs.Approx doc Signed-off-by: monkey92t <golang@88.com> * Add Bun to readme * Upgrade the <sorted set> series of commands (#1792) * Upgrade the <sorted set> series of commands Signed-off-by: monkey92t <golang@88.com> * Cancel the Deprecated mark of ZAddNX and ZAddXX Signed-off-by: monkey92t <golang@88.com> * Explain the use restrictions of KeepTTL. (#1799) Signed-off-by: monkey92t <golang@88.com> * Adjust KeepTTL annotation. Signed-off-by: monkey92t <golang@88.com> * the hello command throws possible errors, It may affect the "read timeout" test result. Signed-off-by: monkey92t <golang@88.com> Co-authored-by: Vladimir Mihailenco <vladimir.webdev@gmail.com> Co-authored-by: ericmillin <31105612+ericmillin@users.noreply.github.com> Co-authored-by: heyanfu <1145291570@qq.com>
mihaitodor
added a commit
to mihaitodor/benthos
that referenced
this pull request
Feb 19, 2023
Jeffail
added a commit
to benthosdev/benthos
that referenced
this pull request
Feb 20, 2023
* Deflake Redis rate limit refresh integration test * Update Redis client libraries Details: - https://redis.com/blog/go-redis-official-redis-client/ - redis/go-redis#1787 * Fix race in redis_streams input * Update changelog --------- Co-authored-by: Ashley Jeffs <ash@jeffail.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support command new options:
XGROUPSupports the CREATECONSUMER subcommand.XTRIM/XADDSupports the MINID trimming strategy and LIMIT argumentXADDSupports the NOMKStREAM argumentXTrim() / XTrimApprox() / XAddArgs.MaxLenApproxmarkDeprecated(removed in v9)Add API:
XGroupCreateConsumerXTrimMaxLenXTrimMaxLenApproxXTrimMinIDXTrimMinIDApproxThere is a bug in the limit option of the xadd and xtrim commands(redis/redis#9046).