Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitlab] Webhook Event Note Hook not registered #45

Open
vncntvandriessche opened this issue Sep 3, 2018 · 1 comment
Open

[gitlab] Webhook Event Note Hook not registered #45

vncntvandriessche opened this issue Sep 3, 2018 · 1 comment

Comments

@vncntvandriessche
Copy link

Hi

I'm currently using the following dependency:

PROJECT                               CONSTRAINT     VERSION        REVISION  LATEST   PKGS USED
gopkg.in/go-playground/webhooks.v3    v3.11.0        v3.11.0        5580947   v3.11.0  2  

I've noticed some of the events formerly handled by functions registered as: IssuesEvents no longer seem to be properly handled. More specifically: When someone reacts to an issue, it no longer seems to create the same hook from gitlab -> It's become some sort of (NotesEvents?).

I opened this repository at tag: v3.13.0 and started searching for this event type in https://github.com/go-playground/webhooks/blob/v3.13.0/gitlab/gitlab.go#L28-L38 but couldn't find it.

Is it possible I'm missing something?

Seems like gitlab now has this type of hook:
notesevent

When I created this application it seems like the notesEvents didn't exist and it was shipped along with the IssuesEvents?

@vncntvandriessche vncntvandriessche changed the title Webhook Event Note Hook not registered [gitlab] Webhook Event Note Hook not registered Sep 3, 2018
@Munsio
Copy link

Munsio commented Apr 1, 2019

Hi,

The "Note events" you are searching for is under the CommentEvents.
https://docs.gitlab.com/ee/user/project/integrations/webhooks.html#comment-events

So in fact you need to listen on the CommentEvents and then check the payload Object and search for the information you need. In your case and according to the gitlab documentation there should be an issue key in the payload.
Here is the code at the specific version: https://github.com/go-playground/webhooks/blob/v3.13.0/gitlab/payload.go#L125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants