Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding gitlab JobEvents to BuildEvents does not make sense #175

Open
finkandreas opened this issue Jul 2, 2023 · 0 comments
Open

Forwarding gitlab JobEvents to BuildEvents does not make sense #175

finkandreas opened this issue Jul 2, 2023 · 0 comments

Comments

@finkandreas
Copy link
Contributor

return eventParsing(BuildEvents, events, payload)

Forwarding this event as a BuildEvents requires that the user subscribes to both JobEvents and BuildEvents when they call hook.Parse(...).
Otherwise the end up with the error message in
return nil, ErrEventNotFound

This leads to confusing code, when one wants to actually subscribe to JobEvents, but must handle it later on as gitlab.BuildEventPayload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant