Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result is wrong while there are multiple group of OR operators #910 #911

Merged
merged 2 commits into from May 1, 2022

Conversation

XIELongDragon
Copy link
Contributor

@XIELongDragon XIELongDragon commented Mar 12, 2022

Fixes Or Enhances

Fix bug #910

type T struct {
   Value int `validate:"eq=1|gte=5,eq=1|lt=7"`
}

t := T{8}

should failed the test

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@XIELongDragon XIELongDragon requested a review from a team as a code owner March 12, 2022 04:08
@coveralls
Copy link

coveralls commented Mar 12, 2022

Coverage Status

Coverage decreased (-0.02%) to 75.244% when pulling 248410d on XIELongDragon:master into f2d3ff7 on go-playground:master.

deankarn
deankarn previously approved these changes Mar 23, 2022
Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

I'll try to merge the next time I do a release.

@deankarn deankarn merged commit af72f63 into go-playground:master May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants