Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #697 - add missing "en" translations for "required" tags #884

Merged
merged 2 commits into from May 1, 2022
Merged

fix #697 - add missing "en" translations for "required" tags #884

merged 2 commits into from May 1, 2022

Conversation

renato0307
Copy link
Contributor

Fixes #697

Draft PR.

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@coveralls
Copy link

coveralls commented Jan 14, 2022 •
edited

Coverage Status

Coverage increased (+0.01%) to 74.93% when pulling 54d1774 on renato0307:fix-697 into f09500f on go-playground:master.

@renato0307 renato0307 changed the title fix #697 fix #697 - add missing "en" translations for "required" tags Jan 14, 2022
@deankarn deankarn marked this pull request as ready for review May 1, 2022 15:46
@deankarn deankarn requested a review from a team as a code owner May 1, 2022 15:46
@deankarn deankarn merged commit d37da5e into go-playground:master May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation for Other tags? Eg: required_without?
3 participants
@renato0307 @coveralls @deankarn