Add DNS RFC 1035 label format validator #833
Conversation
There was a problem hiding this comment.
This looks fine to me other than a few small things.
@deankarn any objections to merging once review items are addressed?
| {"abc-", "dns_rfc1035_label", false}, | ||
| {"abc-123", "dns_rfc1035_label", true}, | ||
| {"ABC", "dns_rfc1035_label", false}, | ||
| {"ABC-123", "dns_rfc1035_label", false}, |
There was a problem hiding this comment.
Given that input may come from someone who has no idea what they're doing, what about some more obtuse edge cases like:
"abc-abc""ABC-ABC""123-abc"""
?
validator_test.go
Outdated
| validate := New() | ||
|
|
||
| for i, test := range tests { | ||
|
|
There was a problem hiding this comment.
nit: remove this blank line? Blank lines are good to denote section breaks for improved readability, but here IMO it just makes it so less LOC fit on a single screen, which actually reduces readability. So just maybe be not quite so quick to insert one.
baked_in.go
Outdated
| // isDnsRFC1035LabelFormat is the validation function for validating if the current field's value is a valid dns RFC 1035 label, defined in RFC 1035 | ||
| func isDnsRFC1035LabelFormat(fl FieldLevel) bool { | ||
| val := fl.Field().String() | ||
|
|
baked_in.go
Outdated
| @@ -2407,3 +2408,10 @@ func isIsoBicFormat(fl FieldLevel) bool { | |||
|
|
|||
| return bicRegex.MatchString(bicString) | |||
| } | |||
|
|
|||
| // isDnsRFC1035LabelFormat is the validation function for validating if the current field's value is a valid dns RFC 1035 label, defined in RFC 1035 | |||
There was a problem hiding this comment.
Break this comment into mulitple lines and end with a period?
No need for it to keep going and going to the right...
|
@jeffwidman |
Enhances
Make sure that you've checked the boxes below before you submit PR:
Change details:
@go-playground/validator-maintainers