Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postcode validator for value and field #759

Merged
merged 3 commits into from May 6, 2021

Conversation

vuon9
Copy link
Contributor

@vuon9 vuon9 commented Apr 25, 2021

Rules for postcode validation

  • postcode_iso3166_alpha2: Use directly with a value of country code in ISO 3316 alpha 2
  • postcode_iso3166_alpha2_field: Use directly with a field which should contain a value of country code in ISO 3316 alpha 2

Notes

  • Original discussion Validate postcode/zipcode #751
  • It does not support ISO 3316 other types, and not for all countries.
  • Added postcode regex for Vietnam (VN) country

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/admins

@deankarn
Copy link
Contributor

Thanks for the PR @vuon9 I'll try and get to it soon. Apologies it might take a while.

@coveralls
Copy link

coveralls commented May 6, 2021

Coverage Status

Coverage decreased (-0.04%) to 75.965% when pulling d08f919 on vuon9:postcode-validator into c206620 on go-playground:master.

@deankarn deankarn merged commit a53d64f into go-playground:master May 6, 2021
@vuon9 vuon9 deleted the postcode-validator branch May 11, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants