Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md - version removed from installation and import #710

Merged
merged 1 commit into from Apr 6, 2021

Conversation

Serj1c
Copy link
Contributor

@Serj1c Serj1c commented Dec 26, 2020

from installation and import parts of the readme file "/v10" was removed (go get did not work with it)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.07% when pulling 26c7037 on Serj1c:updatedReadme into f6584a4 on go-playground:master.

Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@deankarn deankarn merged commit 2b75c46 into go-playground:master Apr 6, 2021
@ByungJun25
Copy link

For me, go get github.com/go-playground/validator/v10 is correct. If I use go get github.com/go-playground/validator, it takes v9.31.0...

Which command is right?

BrianLeishman added a commit to BrianLeishman/validator that referenced this pull request May 5, 2021
fix go-playground#756

Undoes this pr? go-playground#710

Running `go get github.com/go-playground/validator/v10` definitely seems to be the right command. Go getting without the version pulls 9 or just the master. Also importing without the version does not use the current version (v10 at the time of this pr)
deankarn added a commit that referenced this pull request Jul 26, 2021
fix #756

Undoes this pr? #710

Running `go get github.com/go-playground/validator/v10` definitely seems to be the right command. Go getting without the version pulls 9 or just the master. Also importing without the version does not use the current version (v10 at the time of this pr)

Co-authored-by: Dean Karn <Dean.Karn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants