Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-83: ObjectId.String() breaks swagger validation and CLI #84

Merged
merged 1 commit into from Aug 19, 2021

Conversation

dimovnike
Copy link
Contributor

Signed-off-by: Nick Dimov 3619341+dimovnike@users.noreply.github.com

Signed-off-by: Nick Dimov <3619341+dimovnike@users.noreply.github.com>
Copy link
Member

@youyuanwu youyuanwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test in validate pkg after this check-in?

@dimovnike
Copy link
Contributor Author

Can you add a test in validate pkg after this check-in?

Yes.

@casualjim casualjim merged commit 583b813 into go-openapi:master Aug 19, 2021
@dimovnike
Copy link
Contributor Author

Can you add a test in validate pkg after this check-in?

Test is implemented in this PR go-openapi/validate#141

@dimovnike dimovnike deleted the 83-objectid-hex branch August 19, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants