Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve url.Parse behaviour before go1.19 #158

Merged
merged 1 commit into from Aug 13, 2022
Merged

preserve url.Parse behaviour before go1.19 #158

merged 1 commit into from Aug 13, 2022

Conversation

zhsj
Copy link
Contributor

@zhsj zhsj commented Aug 12, 2022

Closes: #157

Signed-off-by: Shengjing Zhu zhsj@debian.org

Closes: #157

Signed-off-by: Shengjing Zhu <zhsj@debian.org>
@youyuanwu
Copy link
Member

From go1.19 documentation:
"
net/url

The URL type now distinguishes between URLs with no authority and URLs with an empty authority. For example, http:///path has an empty authority (host), while http:/path has none.

The new URL field OmitHost is set to true when a URL has an empty authority.
"
This preserves the old behavior.

@youyuanwu youyuanwu merged commit 285d864 into go-openapi:master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestNormalize fails with Go 1.19
2 participants