client: enable configuration of client response interface #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default ClientResponse implementation locks down access to the raw response, which causes difficulty in debugging outside of debug logs. Opening up the configuation gives flexibility to those that need it, while keeping the default for backwards compatability. Current users will not need to make any changes. Signed-off-by: Chad Kunde <Kunde21@gmail.com>
|
Fixes #240 |
casualjim
approved these changes
Oct 14, 2022
|
Sorry I missed this PR for a long time. If you have more in the future feel free to ping me in slack if I don't notice it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default ClientResponse implementation locks down access to the raw
response, which causes difficulty in debugging outside of debug logs.
Opening up the configuation gives flexibility to those that need it,
while keeping the default for backwards compatability. Current users
will not need to make any changes.
Signed-off-by: Chad Kunde Kunde21@gmail.com