Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long term plans for current OpenTracing implementation? #249

Closed
josephwoodward opened this issue Jun 21, 2022 · 5 comments
Closed

Long term plans for current OpenTracing implementation? #249

josephwoodward opened this issue Jun 21, 2022 · 5 comments

Comments

@josephwoodward
Copy link
Contributor

josephwoodward commented Jun 21, 2022 •
edited

Whilst looking at options for tracing egress traffic within services I noticed go-openapi currently supports OpenTracing via its WithOpenTracing extension. Given OpenTracing has since been archived (and the SDK deprecated) and become part of OpenTelemetry I'm interested to know the future plans for this API within go-openapi and whether you'll eventually look at migrating to OpenTelemetry?
@josephwoodward josephwoodward changed the title Future plans for current OpenTracing implementation? Long term plans for current OpenTracing implementation? Jun 21, 2022
@josephwoodward
Copy link
Contributor Author

Would you be open to a PR to introduce a WithTracing extension that adds OpenTelemetry support? We could then look at eventually retiring the WithOpenTracing extension in a future release.

@casualjim
Copy link
Member

all prs are welcome

@josephwoodward josephwoodward mentioned this issue Oct 17, 2022
Merged
@josephwoodward
Copy link
Contributor Author

@casualjim I've started work on this in #254

@josephwoodward
Copy link
Contributor Author

@casualjim I think the pull request is pretty much ready for review now. There are a few additional test cases I'd like to add but the bulk of the implementation is ready whenever you have the time.

@josephwoodward
Copy link
Contributor Author

Now that #254 has been merged it feels like this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@casualjim @josephwoodward