Fixes #246 #248
Merged
Fixes #246 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Makarand <mnsd@divisionsinc.com>
|
would it be possible to add a test? |
okay, let me try to add one. |
MakarandNsd
force-pushed
the
246-fix-optional-file-paramter
branch
from
523f840
to
930a130
Compare
Signed-off-by: Makarand <mnsd@divisionsinc.com>
youyuanwu
approved these changes
Jun 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
==========================================
+ Coverage 80.16% 80.18% +0.01%
==========================================
Files 42 42
Lines 3186 3189 +3
==========================================
+ Hits 2554 2557 +3
Misses 519 519
Partials 113 113
Continue to review full report at Codecov.
|
youyuanwu
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Makarand mnsd@divisionsinc.com
Fixes the error with optional file parameter