Apply path.Join to the incoming URL #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
approved these changes
Apr 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
=======================================
Coverage 80.06% 80.06%
=======================================
Files 42 42
Lines 3171 3171
=======================================
Hits 2539 2539
Misses 521 521
Partials 111 111
Continue to review full report at Codecov.
|
Compare apples to apples by applying path.Join to the incoming URL, as it happens to the internal path. Signed-off-by: Ariel Ferreira <aferreira@bannerengineering.com>
ArFe
force-pushed
the
bug-fix-swagger-middleware-dropping-trailing-slash-not-finding-path
branch
from
e7216d1
to
1d624ea
Compare
casualjim
approved these changes
Apr 25, 2022
ArFe
deleted the
bug-fix-swagger-middleware-dropping-trailing-slash-not-finding-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #238.
Compare apples to apples by applying path.Join to the incoming URL, as it happens to the internal path.