Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage to ~80% #223

Merged
merged 3 commits into from Oct 28, 2021
Merged

Increase test coverage to ~80% #223

merged 3 commits into from Oct 28, 2021

Conversation

kzys
Copy link
Contributor

@kzys kzys commented Oct 25, 2021

There are a few easy targets we can have tests.

This change also removes GetOK in request_test.go. It is somehow duplicated.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #223 (69c0f14) into master (17a5a82) will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   79.19%   80.24%   +1.04%     
==========================================
  Files          43       43              
  Lines        3153     3153              
==========================================
+ Hits         2497     2530      +33     
+ Misses        544      512      -32     
+ Partials      112      111       -1     
Impacted Files Coverage Δ
request.go 87.14% <0.00%> (+32.85%) ⬆️
values.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a5a82...69c0f14. Read the comment docs.

@kzys kzys marked this pull request as draft October 25, 2021 19:34
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@kzys kzys changed the title Increase test coverage ~80% Increase test coverage to ~80% Oct 25, 2021
@kzys kzys marked this pull request as ready for review October 25, 2021 20:20
@youyuanwu youyuanwu merged commit dd12a47 into go-openapi:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants