Fix GitHub Actions on Windows #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
commented
Oct 14, 2021
| @@ -25,4 +25,4 @@ jobs: | |||
| gotestsum_version: 1.7.0 | |||
|
|
|||
| - name: Test | |||
| run: gotestsum --format short-verbose -- -race -timeout=20m -coverprofile=coverage.txt -covermode=atomic ./... | |||
| run: gotestsum --format short-verbose -- -race -timeout=20m -coverprofile=coverage_txt -covermode=atomic ./... | |||
There was a problem hiding this comment.
I honestly don't know why, but . makes Windows unhappy. See https://github.com/go-openapi/runtime/runs/3888315510.
| // Windows doesn't have the system cert pool. | ||
| pool = x509.NewCertPool() | ||
| } else { | ||
| pool, err = x509.SystemCertPool() |
There was a problem hiding this comment.
Does it make sense to not use the system cert pool at all?
There was a problem hiding this comment.
For this test I think this is fine.
youyuanwu
approved these changes
Oct 15, 2021
casualjim
approved these changes
Oct 15, 2021
| // Windows doesn't have the system cert pool. | ||
| pool = x509.NewCertPool() | ||
| } else { | ||
| pool, err = x509.SystemCertPool() |
There was a problem hiding this comment.
For this test I think this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com