Stop preparing the request if an error occurs #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
request.buildHTTP closes the writer but keeps preparing the request if an error occurs. Since the writer is already closed, other following write operations also fail. This commit changes this behaviour so that the function returns earlier and stop the preparation. Signed-off-by: Junpei Kawamoto <kawamoto.junpei@gmail.com>
casualjim
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.buildHTTPcloses the writer but keeps preparing the request if an error occurs. Since the writer is already closed, other following write operations also fail. This PR changes this behaviour so that the function returns earlier and stops the preparation.This PR fixes #215.