Allows base paths to include query parameters #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youyuanwu
reviewed
Aug 24, 2021
youyuanwu
approved these changes
Aug 24, 2021
This is a test case and a fix for go-openapi#207. When the base path of an operation contains a query string, those parameters are: 1. extracted before appending any path parameters to the path 2. merged with the query parameters In the case of a conflict between the parameters passed in the API call and the ones declared in the base path, the former prevails. This gives the end control to clients. Signed-off-by: Julien Silland <julien@soliton.io>
Signed-off-by: Julien Silland <julien@soliton.io>
Signed-off-by: Julien Silland <julien@soliton.io>
Signed-off-by: Julien Silland <julien@soliton.io>
Signed-off-by: Julien Silland <julien@soliton.io>
|
The linter flagged that I was ignoring the return value from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test case and a fix for #207.
When the base path of an operation contains a query string, those parameters are:
In the case of a conflict between the parameters passed in the API call and the ones declared in the base path, the former prevails. This gives end control to clients.