Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MySQL 8.4.0 #866

Open
2 of 6 tasks
dveeden opened this issue May 7, 2024 · 0 comments
Open
2 of 6 tasks

Support MySQL 8.4.0 #866

dveeden opened this issue May 7, 2024 · 0 comments
Assignees

Comments

@dveeden
Copy link
Collaborator

dveeden commented May 7, 2024

MySQL 8.4.0 has removed some of the deprecated "MASTER" and "SLAVE" terms.

--- FAIL: TestSyncerSuite (0.01s)
    --- FAIL: TestSyncerSuite/TestMysqlBinlogCodec (0.00s)
        replication_test.go:52: 
            	Error Trace:	/home/dvaneeden/dev/go-mysql/replication/replication_test.go:52
            	            				/home/dvaneeden/dev/go-mysql/replication/replication_test.go:409
            	Error:      	Received unexpected error:
            	            	ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'MASTER' at line 1
            	Test:       	TestSyncerSuite/TestMysqlBinlogCodec
    --- FAIL: TestSyncerSuite/TestMysqlPositionSync (0.00s)
        replication_test.go:308: 
            	Error Trace:	/home/dvaneeden/dev/go-mysql/replication/replication_test.go:308
            	            				/home/dvaneeden/dev/go-mysql/replication/replication_test.go:340
            	Error:      	Received unexpected error:
            	            	ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'MASTER STATUS' at line 1
            	Test:       	TestSyncerSuite/TestMysqlPositionSync
    --- FAIL: TestSyncerSuite/TestMysqlSemiPositionSync (0.00s)
        replication_test.go:308: 
            	Error Trace:	/home/dvaneeden/dev/go-mysql/replication/replication_test.go:308
            	            				/home/dvaneeden/dev/go-mysql/replication/replication_test.go:403
            	Error:      	Received unexpected error:
            	            	ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'MASTER STATUS' at line 1
            	Test:       	TestSyncerSuite/TestMysqlSemiPositionSync
    --- FAIL: TestSyncerSuite/TestStartBackupEndInGivenTime (0.00s)
        replication_test.go:52: 
            	Error Trace:	/home/dvaneeden/dev/go-mysql/replication/replication_test.go:52
            	            				/home/dvaneeden/dev/go-mysql/replication/backup_test.go:16
            	Error:      	Received unexpected error:
            	            	ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'MASTER' at line 1
            	Test:       	TestSyncerSuite/TestStartBackupEndInGivenTime
FAIL
FAIL	github.com/go-mysql-org/go-mysql/replication	0.015s
FAIL
--- FAIL: TestCanalSuite (1.13s)
    --- FAIL: TestCanalSuite/TestCanal (0.10s)
        canal_test.go:138: 
            	Error Trace:	/home/dvaneeden/dev/go-mysql/canal/canal_test.go:138
            	Error:      	Received unexpected error:
            	            	ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'MASTER STATUS' at line 1
            	            	github.com/pingcap/errors.AddStack
            	            		/home/dvaneeden/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20221009092201-b66cddb77c32/errors.go:174
            	            	github.com/pingcap/errors.Trace
            	            		/home/dvaneeden/go/pkg/mod/github.com/pingcap/errors@v0.11.5-0.20221009092201-b66cddb77c32/juju_adaptor.go:15
            	            	github.com/go-mysql-org/go-mysql/canal.(*Canal).GetMasterPos
            	            		/home/dvaneeden/dev/go-mysql/canal/sync.go:314
            	            	github.com/go-mysql-org/go-mysql/canal.(*Canal).CatchMasterPos
            	            		/home/dvaneeden/dev/go-mysql/canal/sync.go:347
            	            	github.com/go-mysql-org/go-mysql/canal.(*canalTestSuite).TestCanal
            	            		/home/dvaneeden/dev/go-mysql/canal/canal_test.go:137
            	            	reflect.Value.call
            	            		/usr/lib/golang/src/reflect/value.go:596
            	            	reflect.Value.Call
            	            		/usr/lib/golang/src/reflect/value.go:380
            	            	github.com/stretchr/testify/suite.Run.func1
            	            		/home/dvaneeden/go/pkg/mod/github.com/stretchr/testify@v1.8.4/suite/suite.go:197
            	            	testing.tRunner
            	            		/usr/lib/golang/src/testing/testing.go:1689
            	            	runtime.goexit
            	            		/usr/lib/golang/src/runtime/asm_amd64.s:1695
            	Test:       	TestCanalSuite/TestCanal
    canal_test.go:91: Start testing the heartbeat and read timeout
FAIL
FAIL	github.com/go-mysql-org/go-mysql/canal	1.140s
FAIL
 WARNING: --master-data is deprecated and will be removed in a future version. Use --source-data instead.
mysqldump: Couldn't execute 'SHOW MASTER STATUS': You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'MASTER STATUS' at line 1 (1064)
--- FAIL: TestSchemaSuite (0.37s)
    --- FAIL: TestSchemaSuite/TestDump (0.04s)
        schema_test.go:103: 
            	Error Trace:	/home/runner/work/go-mysql/go-mysql/dump/schema_test.go:103
            	Error:      	Received unexpected error:
            	            	exit status 2
            	Test:       	TestSchemaSuite/TestDump
    --- FAIL: TestSchemaSuite/TestParse (0.02s)
        schema_test.go:119: 
            	Error Trace:	/home/runner/work/go-mysql/go-mysql/dump/schema_test.go:119
            	Error:      	Received unexpected error:
            	            	exit status 2
            	Test:       	TestSchemaSuite/TestParse
FAIL
FAIL	github.com/go-mysql-org/go-mysql/dump	0.377s
  • Fix TestSyncerSuite
  • Fix TestCanalSuite
  • Fix failover/server.go (MASTER and SLAVE)
  • Fix dump/parser.go and dump/parser_test.go (MASTER, MASTER_LOG_FILE, ...)
  • Stop using mysql_ssl_rsa_setup
  • Fix TestSchemaSuite with MySQL v8.4.0 and older (8.0.x) mysqldump and update CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant