Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/stretchr/testify from 1.7.1 to 1.8.0 #720

Closed
mrb113 opened this issue Jul 19, 2022 · 5 comments · Fixed by #722
Closed

Bump github.com/stretchr/testify from 1.7.1 to 1.8.0 #720

mrb113 opened this issue Jul 19, 2022 · 5 comments · Fixed by #722

Comments

@mrb113
Copy link

mrb113 commented Jul 19, 2022

1.7.1 has a vulnerable dependency yaml.v3 that's fixed in 1.8.0. Anyone using go-mysql who's running security tooling is getting warnings about the following:
Security bug: https://security.snyk.io/vuln/SNYK-GOLANG-GOPKGINYAMLV3-2952714

To resolve, you should be able to do:

go get github.com/stretchr/testify
go mod tidy

I don't see any breaking changes between the 1.7.1 and 1.8.0 versions

@lance6716
Copy link
Collaborator

Hi, do you have time to submit a PR 😄

@mrb113
Copy link
Author

mrb113 commented Jul 25, 2022

I don't have a development environment set up for this project - filing an issue because we use it as a dependency.

@mrb113
Copy link
Author

mrb113 commented Jul 28, 2022

thanks for addressing this! looking forward to the release w/ the fix

@lance6716
Copy link
Collaborator

thanks for addressing this! looking forward to the release w/ the fix

PTAL @atercattus

@atercattus
Copy link
Member

atercattus commented Aug 31, 2022

Hello.

As I see we still use the wrong yaml.v3 version:

$ go mod graph | grep yaml.v3@v3.0.0
github.com/stretchr/testify@v1.7.1 gopkg.in/yaml.v3@v3.0.0-20200313102051-9f266ea9e77c

$ go mod graph | grep github.com/stretchr/testify@v1.7.1
github.com/stretchr/objx@v0.4.0 github.com/stretchr/testify@v1.7.1

And objx uses wrong yaml.v3 in the latest version.

And the latest testify uses wrong objx.

And as I see you know about this stretchr/objx#121 :)

We need to update objx too to fix this vulnerability...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants