Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Etag format prevents its validation and correct usage. #193

Closed
pablolagos opened this issue Apr 27, 2020 · 0 comments · Fixed by #194
Closed

Invalid Etag format prevents its validation and correct usage. #193

pablolagos opened this issue Apr 27, 2020 · 0 comments · Fixed by #194
Labels

Comments

@pablolagos
Copy link

When the Etag for static files is generated it is sent without quotes, so later the validation is not done correctly:

Response headers:

HTTP/1.1 200 OK
Accept-Ranges: bytes
Content-Length: 104006
Content-Type: text/css; charset=utf-8
Etag: 8JmZhmJvb3RzdHJhcC5taW4uY3NzTW9uLCAyNyBBcHIgMjAyMCAxNTowMDowNiBHTVQ=
Last-Modified: Mon, 27 Apr 2020 15:00:06 GMT

As described in RFC 7232, the Etag must be in quotes:

https://tools.ietf.org/html/rfc7232#section-2.3

@unknwon unknwon linked a pull request Apr 28, 2020 that will close this issue
@unknwon unknwon added the bug label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants