New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
response_writer: support http/2 push #188
Conversation
Action items after merge:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! See inline comments.
resp := httptest.NewRecorder() | ||
rw := NewResponseWriter("GET", resp) | ||
_, ok := rw.(http.Pusher) | ||
So(ok, ShouldBeTrue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No test case for the call of pusher.Push
method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will not lie to you. As I never used Convoy I got a little bit confused how to use it in this more complex use case. As I have other demands from my employer if you could help me out on this or give a waiver in this method I would appreciate it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! I'll see what I can do and push to this PR.
Co-Authored-By: ᴜɴᴋɴᴡᴏɴ <u@gogs.io>
Travis CI is broken, I'm going to merge as-is, and might fix test in the future. |
PR to response the #136 feature request