Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response_writer: support http/2 push #188

Merged
merged 4 commits into from Mar 27, 2020
Merged

response_writer: support http/2 push #188

merged 4 commits into from Mar 27, 2020

Conversation

jeffprestes
Copy link
Contributor

PR to response the #136 feature request

@unknwon
Copy link
Contributor

unknwon commented Mar 25, 2020

Action items after merge:

Copy link
Contributor

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! See inline comments.

response_writer.go Outdated Show resolved Hide resolved
response_writer.go Outdated Show resolved Hide resolved
resp := httptest.NewRecorder()
rw := NewResponseWriter("GET", resp)
_, ok := rw.(http.Pusher)
So(ok, ShouldBeTrue)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test case for the call of pusher.Push method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not lie to you. As I never used Convoy I got a little bit confused how to use it in this more complex use case. As I have other demands from my employer if you could help me out on this or give a waiver in this method I would appreciate it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! I'll see what I can do and push to this PR.

@unknwon unknwon changed the title add http/2 push support respose_writer: support http/2 push Mar 25, 2020
@unknwon unknwon changed the title respose_writer: support http/2 push response_writer: support http/2 push Mar 25, 2020
@unknwon
Copy link
Contributor

unknwon commented Mar 27, 2020

Travis CI is broken, I'm going to merge as-is, and might fix test in the future.

@unknwon unknwon merged commit b2cd309 into go-macaron:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants