Skip to content

context: add AllParams() #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 25, 2020
Merged

context: add AllParams() #187

merged 6 commits into from
Feb 25, 2020

Conversation

xmh19936688
Copy link
Contributor

It is usefull with for-each.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
It is usefull with for-each.
@unknwon
Copy link
Contributor

unknwon commented Feb 24, 2020

Thanks for your PR!

Could you add a unit test around this line? https://github.com/go-macaron/macaron/blob/master/context_test.go#L173

add unit test for AllParams()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@unknwon
Copy link
Contributor

unknwon commented Feb 25, 2020

Thanks again, merging!

@unknwon unknwon changed the title add func AllParams() for Context context: add AllParams() Feb 25, 2020
@unknwon unknwon merged commit 5993313 into go-macaron:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants