Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer zerologr to go-logr organization #59

Closed
hn8 opened this issue Jul 27, 2021 · 7 comments
Closed

Transfer zerologr to go-logr organization #59

hn8 opened this issue Jul 27, 2021 · 7 comments
Assignees

Comments

@hn8
Copy link
Contributor

hn8 commented Jul 27, 2021

https://github.com/screenleap/zerologr/tree/master

@hn8 hn8 closed this as completed Jul 30, 2021
@hn8 hn8 reopened this Jul 31, 2021
@hn8 hn8 closed this as completed Aug 3, 2021
@hn8 hn8 changed the title Zerologr for go-logr? Transfer zerologr to go-logr organization Aug 29, 2021
@hn8 hn8 reopened this Aug 29, 2021
@hn8
Copy link
Contributor Author

hn8 commented Sep 10, 2021

@thockin @pohly Moved most logic of zerologr to zerolog. Now, it is less than 100 LoC, minimal maintenance needed. Would you please consider hosting zerologr under go-logr? Will love to help maintaining with PRs in the future. Thanks!

This was referenced Sep 14, 2021
@thockin
Copy link
Contributor

thockin commented Sep 21, 2021

I'm not hard against it, but I have a small worry that I end up putting myself into a flow I have no real context for. Why is this better?

Also, see go-logr/zapr#43

@thockin thockin self-assigned this Sep 21, 2021
@hn8
Copy link
Contributor Author

hn8 commented Sep 22, 2021

@thockin Totally understand your concern. Zap and Zerlog are popular alternatives for JSON logging. Originally we tried Zapr because it looks like the "official" implementation (being part of go-logr). If Zerologr is part of go-logr, I can convert 2 open source projects to use it (instead of my own repo). Zerologr's LoC is minimal, and I would love to help maintain it if you don't mind. Thanks!

@pohly
Copy link
Contributor

pohly commented Sep 22, 2021

My two cents: I don't know much about zerolog. It seems to be used less than zap (imported by is 3,952 vs. 24,820 according to pkg.go.dev). But it looks like a well-maintained project and as you did the direct comparison and found zerolog to be more suitable, I thing we should consider it.

The question "inside go-logr or elsewhere" boils down to maintenance. Loggers are not automatically becoming "official" just because they are hosted here, it just means that a certain set of people (recently mostly Tim, now also me) promise to maintain them.

As you have offered to help with that part, I'm inclined to include zerologr under go-logr.

@hn8
Copy link
Contributor Author

hn8 commented Sep 23, 2021

Thanks! I tried to optimize Zapr initially, but Zerologr is always 2-3x faster on benchmark. I suspect the main difference is how Zap passes variadic argument spread down in call stack. I can help maintain both Zerologr and Zapr since those two are used by pion/ion-sfu and livekit.

@hn8
Copy link
Contributor Author

hn8 commented Sep 24, 2021

@thockin @pohly I have added you as Admin role of Zerologr. Would you please try transfering repo if possible?

@thockin
Copy link
Contributor

thockin commented Sep 24, 2021

OK, I'll give it a shot

@thockin thockin closed this as completed Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants