Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move testing -> testr, deprecate, alias old names #140

Merged
merged 1 commit into from Mar 17, 2022
Merged

Move testing -> testr, deprecate, alias old names #140

merged 1 commit into from Mar 17, 2022

Conversation

thockin
Copy link
Contributor

@thockin thockin commented Mar 15, 2022

This avoids the pkg name overlap with standard "testing".

Fixes #138

pohly
pohly requested changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The new klog/ktesting just got released, so as you are touching that line I added a suggestion for it.

I'm also wondering about best practices for constructor function namining.

README.md Outdated Show resolved Hide resolved
testr/testr.go Outdated Show resolved Hide resolved
@thockin
Move testing -> testr, deprecate, alias old names
5377a98 
This avoids the pkg name overlap with standard "testing".
thockin
thockin commented Mar 16, 2022
View reviewed changes
Copy link
Contributor Author

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New push with changes is up! Thanks.

README.md Outdated Show resolved Hide resolved
testr/testr.go Outdated Show resolved Hide resolved
pohly
pohly approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give @rollulus some days to also look at this and then merge it.

rollulus
rollulus approved these changes Mar 17, 2022
View reviewed changes
Copy link

@rollulus rollulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this and thanks in general forlogr!

@pohly pohly merged commit b359493 into go-logr:master Mar 17, 2022
@thockin
Copy link
Contributor Author

thockin commented Mar 17, 2022

I tagged v1.2.3 with this

@tonglil tonglil mentioned this pull request Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@rollulus rollulus rollulus approved these changes

Assignees

@pohly pohly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Would it be possible to rename pkg testing?
3 participants
@thockin @pohly @rollulus