Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint error and tests for Go versions #135

Merged
merged 1 commit into from Jan 27, 2022
Merged

Fix lint error and tests for Go versions #135

merged 1 commit into from Jan 27, 2022

Conversation

thockin
Copy link
Contributor

@thockin thockin commented Jan 27, 2022

Fixes #134

@thockin
Copy link
Contributor Author

thockin commented Jan 27, 2022

Super not helpful github! The tests just didn't run, but it doesn't show that.

@thockin
Copy link
Contributor Author

thockin commented Jan 27, 2022

Now they are running.

@thockin
Fix GH actions for Go versions, drop 1.14
e438a74 
Also fix a lint-warning, which ensures the tests have something to test.
@thockin thockin mentioned this pull request Jan 27, 2022
Closed
@thockin
Copy link
Contributor Author

thockin commented Jan 27, 2022

Looks like it works now, @pohly

@pohly pohly merged commit ec7c16c into go-logr:master Jan 27, 2022
@pohly pohly mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

Assignees

@pohly pohly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GH actions tests always use go 1.15
2 participants
@thockin @pohly