Send fix v3 too #264
Merged
Send fix v3 too #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My bad. I should have caught that. We will look into tidying this up, and deprecating pre-modules versions. Merging, and will tag again. EDIT: For clarification, this is because go-ldap was v3 to match the ldap v3 (the standard). When switching to modules, this proves a little bit of an issue. In order to maintain backwards compatibility, we segregated by folder (as opposed to using a new default branch). This leads to some duplicated commits, and are investigating ways to improve this, without breaking pre-1.11 modules. |
|
Tagged v3.1.10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very sorry, but got quite confused when I didn't find this change pulling down v3.1.9 tag. Turns out conn.go is largely similar in the root and v3 and I'd only fixed the root half. We actually use v3. :(