sendMessage closing race fix #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… isClosing test at the top of sendMessageWithFlags, and a subsequently ignored test in sendProcessMessage
|
Merged and tagged v3.1.9 - Thanks for contributing! |
|
I saw that, and then confusingly couldn't find the fix on our side.
Turns out I fixed v2 but not also v3 which we use. I've submitted
another PR for it, hopefully not too late.
…On Wed, May 6, 2020 at 09:15, Stefan McShane ***@***.***> wrote:
Merged and tagged v3.1.9 - Thanks for contributing!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#263 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJNHLV3RYXPCV3JZYR6JO3RQGEJ3ANCNFSM4MWNQ2ZQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the handling of a race where the connection is closed between the isClosing test at the top of sendMessageWithFlags, and a subsequently ignored test in sendProcessMessage.
We were encountering this rarely in our CI runs where for some reason the LDAP server drops the connection just after Dial but in the middle of our first GetUserBindDN call. The message fails to send but the sendMessage returns nil, then message receiving stalls reading from the responses channel for a message that will never arrive.