log/term: fix build on GOOS=js GOARCH=wasm #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, the build would fail, as IsTerminal isn't defined on that platform: $ GOOS=js GOARCH=wasm go build # github.com/go-kit/kit/log/term ./term.go:14:6: undefined: IsTerminal The reason is pretty simple; js/wasm doesn't have syscalls, and thus it doesn't have an "is a terminal" syscall. Grouping it with appengine to always assume that the output is not a terminal is good enough for now, as it at least makes the package build. No change is needed in any other file, because none of the other IsTerminal +build lines include js/wasm in any way.
|
I realise that go-kit probably doesn't support js/wasm explicitly right now, but I have a dependency that indirectly ends up depending on your log packages, for better or worse. And there really isn't a reason why a log package should require an "is a terminal" syscall to work. |
|
Fine by me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the build would fail, as IsTerminal isn't defined on
that platform:
The reason is pretty simple; js/wasm doesn't have syscalls, and thus it
doesn't have an "is a terminal" syscall.
Grouping it with appengine to always assume that the output is not a
terminal is good enough for now, as it at least makes the package build.
No change is needed in any other file, because none of the other
IsTerminal +build lines include js/wasm in any way.