Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: grpc conn manager #862

Open
MaruHyl opened this issue Apr 15, 2019 · 4 comments
Open

Feature request: grpc conn manager #862

MaruHyl opened this issue Apr 15, 2019 · 4 comments

Comments

@MaruHyl
Copy link
Contributor

MaruHyl commented Apr 15, 2019

Ref: https://github.com/go-kit/kit/blob/master/examples/apigateway/main.go#L184

Based on this hint, I wrote some code and wondered if this could be contributed to the kit. Do you have time to look at it @ChrisHines ? If it is not good enough, can it be an example?
Here, https://github.com/MaruHyl/xgrpc

@MaruHyl
Copy link
Contributor Author

MaruHyl commented Apr 15, 2019

@peterbourgon This is an initial version. Can you give some suggestions?

@peterbourgon
Copy link
Member

@basvanbeek I think you are the original author of that comment, can you provide some feedback? I would have to spend some time to get up to speed to be able to comment effectively.

@basvanbeek
Copy link
Member

I will take a look on Thursday.

@basvanbeek
Copy link
Member

Not forgotten, simply have had no time yet. Still on my todo list.

@basvanbeek basvanbeek self-assigned this Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants