Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SD - Registrator error handling #780

Open
jstoja opened this issue Oct 23, 2018 · 1 comment
Open

SD - Registrator error handling #780

jstoja opened this issue Oct 23, 2018 · 1 comment
Labels
enhancement help wanted newbie friendly

Comments

@jstoja
Copy link

jstoja commented Oct 23, 2018 •
edited

Is there any reason for not returning any error on the registration of a service?

kit/sd/registrar.go

Line 11 in ec0cc13

Register()

From my point of view, if a service doesn't manage to correctly register, then it might be nice to retry later. Binding to events to watch if you're correctly registered seems overkilled compared to just checking this error.

What are your thoughts?
@peterbourgon
Copy link
Member

Sure, happy to take a PR with a fix. Be sure to fix all implementations of Registrar :)

@jstoja jstoja mentioned this issue Oct 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted newbie friendly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterbourgon @jstoja