Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing support for thrift #666

Open
mqliang opened this issue Feb 23, 2018 · 2 comments
Open

Tracing support for thrift #666

mqliang opened this issue Feb 23, 2018 · 2 comments

Comments

@mqliang
Copy link

mqliang commented Feb 23, 2018

Is it possible to add tracing support for Thrift ?

@peterbourgon
Copy link
Member

This would involve mirroring the Server and Client types, as in the other transport packages, and providing the relevant hooks, e.g. ServerBefore, ServerAfter, etc. Certainly possible.

@basvanbeek
Copy link
Member

Thrift has no concept of metadata/headers so you'll need to envelope your messages and have some way of figuring out if a message was enveloped or not. If only producing and consuming services under your wings this is obviously not difficult as you control the message payload, but in a polyglot environment you'll need to see what the already established patterns are. I suggest looking at finagle which has dealt with this exact issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants