Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fargo library #1167

Merged
merged 1 commit into from Aug 19, 2021
Merged

Conversation

sagikazarmark
Copy link
Contributor

See #1127

I think it's still worth updating, even if we decide to deprecate it.

@peterbourgon
Copy link
Member

I understood we'd be doing updates just prior to releases?

@sagikazarmark
Copy link
Contributor Author

Yep, I mostly wanted to use this PR as a reference for the discussion about deprecating/dropping the eureka. The change is trivial, no breaking changes in the library, so I'd say it's worth upgrading along with a deprecation notice.

I don't mind closing this PR and updating dependencies before the next release.

@peterbourgon
Copy link
Member

OK, as long as it's a one-off :) Just want to reiterate that we shouldn't be processing an unending stream of "update so-and-so dependency" PRs.

@sagikazarmark
Copy link
Contributor Author

Let's repurpose this PR then into deprecating eureka (joined with a dependency update). But that would require having a conversation/making a decision about what and how to deprecate.

Since generics are expected to be available in 1.18 and #843 proposes a large refactor once generics are available, maybe we can start planning that. But as @ChrisHines pointed out earlier: making large changes in smaller chunks is better, so if the introduction of generics is targeted for 1.18, maybe the next Go kit version should be released somewhere after Go 1.17, deprecating the packages that we intend to remove/relocate as part of the larger refactor. That would give people enough time to start migrating away (given these packages actively used).

@ChrisHines
Copy link
Member

I would like a go-kit release sometime after Go 1.17 is out that updates our go.mod with the changes that version of Go brings (#1105).

@sagikazarmark sagikazarmark added this to the v0.12.0 milestone Aug 16, 2021
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark merged commit 274c344 into go-kit:master Aug 19, 2021
@sagikazarmark sagikazarmark deleted the update-fargo branch August 19, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants