Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf #1115

Merged
merged 1 commit into from Jun 24, 2021
Merged

Conversation

sagikazarmark
Copy link
Contributor

This PR updates protobuf (with the relevant generators) and the related generated (and version controlled) code.

The code was generated using the following Nix shell setup:

{ pkgs ? import (fetchTarball "https://github.com/NixOS/nixpkgs/archive/432fc2d9a67f92e05438dff5fdc2b39d33f77997.tar.gz") {} }:

pkgs.mkShell {
  buildInputs = [
    pkgs.git
    pkgs.go_1_16
    pkgs.protobuf
    pkgs.protoc-gen-go
    pkgs.protoc-gen-go-grpc
  ];
}

Related to #1109

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Copy link
Member

@ChrisHines ChrisHines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a gRPC expert, so I can't really validate all of the changes here. I do find it fascinating that go mod tidy doesn't make any changes to go.sum in this case, but that reproduces for me locally. Looks good as far as I can tell, though.

@sagikazarmark
Copy link
Contributor Author

Most of the changes are in the code generator, but the new proto library should be backwards compatible with the old one. The rest of the changes only affect tests, not the library itself.

I guess the reason for no go.sum changes is that there are no observed changes in the list of dependencies: the new proto lib is a dependency of the old one (or vice versa?) and probably something else relies on the old library as well, so it doesn't disappear from go.sum. But I agree, the odds for this to happen are pretty low.

@sagikazarmark sagikazarmark added this to the v0.11.0 milestone Jun 24, 2021
@sagikazarmark sagikazarmark merged commit e12e92a into go-kit:master Jun 24, 2021
@sagikazarmark sagikazarmark deleted the update-grpc-proto branch June 24, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants