New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in auth/jwt package #1071
Milestone
Comments
amidam
pushed a commit
to amidam/kit
that referenced
this issue
Jun 2, 2021
* define JWTContextKey as a new constant * mark JWTTokenContextKey as a deprecated constant * revise corresponding error messages
amidam
pushed a commit
to amidam/kit
that referenced
this issue
Jun 2, 2021
* define JWTContextKey as a new constant * mark JWTTokenContextKey as a deprecated constant * revise corresponding error messages
peterbourgon
pushed a commit
that referenced
this issue
Jun 19, 2021
* Fix typo in jwt package * change JWTTokenContextKey to JWTContextKey * revise errors as well as comments * Revision of typo fixing in jwt package * revert the API identifier to its previous value * add JWTTokenContextKey side by side of JWTContextKey for historical compatibility * Fixed a typo in JWT package (#1071) * define JWTContextKey as a new constant * mark JWTTokenContextKey as a deprecated constant * revise corresponding error messages * Fixed a typo in JWT package (#1071) * define JWTContextKey as a new constant * mark JWTTokenContextKey as a deprecated constant * revise corresponding error messages Co-authored-by: Amid <amid.dev@protonmail.com>
Fixed in #1070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have noticed a typo which was repeated a couple of times in
auth/jwt
package.As JWT stands for JSON Web Token, so the Token after JWT is somehow redundant.
I was wondering if you are OK to revise all of the occurrences of
JWT Token
toJWT
?This change also includes the revision of
JWTTokenContextKey
toJWTContextKey
.The text was updated successfully, but these errors were encountered: