Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key: ignore empty values in ValueWithShadows #316

Merged
merged 1 commit into from Feb 10, 2022

Conversation

unknwon
Copy link
Member

@unknwon unknwon commented Feb 10, 2022

Describe the pull request

Empty values of shadow keys are ignored in the returned list of ValueWithShadows.

Link to the issue: #294

Checklist

  • I agree to follow the Code of Conduct by submitting this pull request.
  • I have read and acknowledge the Contributing guide.
  • I have added test cases to cover the new code.

@unknwon unknwon linked an issue Feb 10, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #316 (3428ffe) into main (c71eccd) will decrease coverage by 0.23%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   88.21%   87.97%   -0.24%     
==========================================
  Files           9        9              
  Lines        1349     1364      +15     
==========================================
+ Hits         1190     1200      +10     
- Misses         96       98       +2     
- Partials       63       66       +3     

@unknwon unknwon merged commit 39f9e49 into main Feb 10, 2022
@unknwon unknwon deleted the jc/omit-empty-shadow-values branch February 10, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip empty shadow values when saving to file
1 participant