Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: add HasSection method #308

Merged
merged 3 commits into from Nov 30, 2021
Merged

file: add HasSection method #308

merged 3 commits into from Nov 30, 2021

Conversation

bryanpedini
Copy link
Contributor

copied implementation from section.go

What problem should be fixed?

Feature proposal #271.

Have you added test cases to catch the problem?

Yes indeed (after seeing this question, but I digress).

@unknwon unknwon changed the title Feature has section file: add HasSection Nov 30, 2021
@unknwon unknwon changed the title file: add HasSection file: add HasSection method Nov 30, 2021
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

file_test.go Outdated Show resolved Hide resolved
file_test.go Outdated Show resolved Hide resolved
@unknwon unknwon linked an issue Nov 30, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #308 (94a5bcc) into main (c2f10d6) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   88.13%   88.30%   +0.16%     
==========================================
  Files           9        9              
  Lines        1357     1351       -6     
==========================================
- Hits         1196     1193       -3     
+ Misses         98       96       -2     
+ Partials       63       62       -1     

@unknwon unknwon merged commit b505416 into go-ini:main Nov 30, 2021
@unknwon
Copy link
Member

unknwon commented Nov 30, 2021

https://github.com/go-ini/ini/releases/tag/v1.66.0 has been tagged for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HasSection function proposal
2 participants