Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creation of default section #301

Merged

Conversation

tphilippeau-tower
Copy link
Contributor

What problem should be fixed?

When the DEFAULT section is removed from the ini file, it cannot be requested back in using the empty string.
It currently return a nil pointer, instead of a new section

Have you added test cases to catch the problem?

Yes

… DEFAULT section

also add go.mod to comply with go modules

Change-Id: I38e9131b2c995bf28bff8475bf7e096d04edcc4b
Signed-off-by: Thomas Philippeau <tphilippeau@tower-research.com>
Change-Id: I6211ca388560e21c172ee870ee8066bdded61b95
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon merged commit 1c1c7ac into go-ini:main Nov 12, 2021
@unknwon
Copy link
Member

unknwon commented Nov 12, 2021

https://github.com/go-ini/ini/releases/tag/v1.64.0 has been tagged for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants