Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key: add AllowDuplicateShadowValues option #298

Merged
merged 2 commits into from Sep 7, 2021

Conversation

dwmunster
Copy link
Contributor

Copied from #285 since I don't seem to be able to change the target of that one.

What problem should be fixed?

Fixes #284.

Have you added test cases to catch the problem?

Test cases have been added to key_test.go for both the default and new cases.

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #298 (3a1028d) into main (b52868c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   88.10%   88.11%           
=======================================
  Files           9        9           
  Lines        1354     1355    +1     
=======================================
+ Hits         1193     1194    +1     
  Misses         98       98           
  Partials       63       63           

Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@unknwon unknwon changed the title Add AllowDuplicateShadowValues option key: add AllowDuplicateShadowValues option Sep 7, 2021
@unknwon unknwon merged commit 326d24f into go-ini:main Sep 7, 2021
@unknwon
Copy link
Member

unknwon commented Sep 7, 2021

https://github.com/go-ini/ini/releases/tag/v1.63.0 has been published for this merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Read Duplicate Values for Shadowed Keys
2 participants