Skip to content

Support Short-circuit load #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2020
Merged

Support Short-circuit load #261

merged 2 commits into from
Sep 5, 2020
+55 −1

Conversation

ygj6
Copy link
Contributor

@ygj6 ygj6 commented Sep 1, 2020 •
edited
Loading

What problem should be fixed?

Short-circuit load #180

  1. The ShortCircuit option is adde
  2. A judgment is added to the Reload() method to implement short-circuit load.

Note: When ShortCircuit and Loose are both true, ShortCircuit has priority over Loose.

Have you added test cases to catch the problem?

Yes, all CI pass the test.

unknwon
unknwon requested changes Sep 3, 2020
View reviewed changes
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please see inline comments.

@unknwon unknwon added the status: reviewed The pull request has been reviewed label Sep 3, 2020
unknwon
unknwon reviewed Sep 4, 2020
View reviewed changes
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up! Few more styling comments.

unknwon
unknwon reviewed Sep 4, 2020
View reviewed changes
unknwon
unknwon approved these changes Sep 5, 2020
View reviewed changes
Copy link
Member

@unknwon unknwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for keeping this up!

@unknwon
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
93f60be
@unknwon unknwon merged commit fcd0515 into go-ini:master Sep 5, 2020
@unknwon unknwon mentioned this pull request Sep 5, 2020
Closed
@unknwon
Copy link
Member

unknwon commented Sep 5, 2020

https://github.com/go-ini/ini/releases/tag/v1.61.0 has tagged for this merge.

@ygj6 ygj6 deleted the issue180 branch September 5, 2020 08:56
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknwon unknwon

Assignees
No one assigned
Labels
status: reviewed The pull request has been reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ygj6 @unknwon