Allow alternative delimiter for child sections #255
Merged
+70
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ini: added option for ChildSectionDelimiter
file: added default for ChildSectionDelimiter (".") to maintain current behavior by default
section:
- append ChildSectionDelimiter instead of "." when checking if each section name begins with prefix
- use ChildSectionDelimiter instead of "." when checking for LastIndex of delimiter
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 86.25% 86.28% +0.02%
==========================================
Files 9 9
Lines 1885 1888 +3
==========================================
+ Hits 1626 1629 +3
Misses 198 198
Partials 61 61
|
|
v1.60.0 has been tagged for this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem should be fixed?
No problem exists. This feature is useful to me, and maybe to others: allowing to specify an alternative delimiter (instead of ".") for separating child section name components.
ini: added option for ChildSectionDelimiter
file: added default for ChildSectionDelimiter (".") to maintain current behavior by default
section:
Have you added test cases to catch the problem?
Yes, the new feature is tested.