Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make this package SQLite implementation agnostic #160

Open
aymanbagabas opened this issue Jul 5, 2023 · 0 comments · May be fixed by #161
Open

Make this package SQLite implementation agnostic #160

aymanbagabas opened this issue Jul 5, 2023 · 0 comments · May be fixed by #161
Assignees
@jinzhu

Comments

@aymanbagabas
Copy link

Describe the feature

It would be awesome if this package could be independent of go-sqlite3 and instead, use go-sqlite3 (sqlite3) when CGO_ENABLED=1 and use modernc.org/sqlite when not.

Motivation

This allows the user to choose between either go-sqlite3 (sqlite3) or modernc.org/sqlite (sqlite) pure-go implementation. go-sqlite3 is excellent, but CGO is a lot to deal with.

The https://github.com/glebarez/sqlite driver is behind on many commits, it would be much simpler to maintain one codebase for multiple drivers rather than two, especially since they are almost the same.

Related Issues

#77 #72 #93 #35
aymanbagabas added a commit to aymanbagabas/sqlite that referenced this issue Jul 5, 2023
@aymanbagabas
feat: use pure-go implementation when cgo is disabled
e4f9f7a 
This implements a pure-go alternative driver whenever CGO_ENABLED=0

Related: go-gorm#93
Fixes: go-gorm#35
Fixes: go-gorm#72
Fixes: go-gorm#77
Fixes: go-gorm#160
@aymanbagabas aymanbagabas linked a pull request Jul 5, 2023 that will close this issue
Open
3 tasks
jramsgz added a commit to jramsgz/ArticPad that referenced this issue Aug 6, 2023
@jramsgz
fix: change sqlite3 package to avoid enabling CGO
0155e54 
Will revert this commit when this gets closed
go-gorm/sqlite#160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinzhu jinzhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use pure-go implementation when cgo is disabled aymanbagabas/sqlite
2 participants
@jinzhu @aymanbagabas