Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alter serial column #98

Merged
merged 4 commits into from Apr 24, 2022
Merged

fix: alter serial column #98

merged 4 commits into from Apr 24, 2022

Conversation

a631807682
Copy link
Member

@a631807682 a631807682 commented Apr 9, 2022 •
edited

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

AlterColumn throw error when type sercial
Do I need to create a test on gorm?

go-gorm/gorm#5047

User Case Description

@a631807682 a631807682 mentioned this pull request Apr 9, 2022
Merged
3 tasks
a631807682
a631807682 commented Apr 9, 2022
View reviewed changes
migrator.go Outdated Show resolved Hide resolved
@a631807682 a631807682 changed the title fix: alter sercial column fix: alter serial column Apr 20, 2022
jinzhu
jinzhu reviewed Apr 24, 2022
View reviewed changes
migrator.go Outdated Show resolved Hide resolved
@jinzhu
Copy link
Member

jinzhu commented Apr 24, 2022

In general look great, thank you for your PR.

@a631807682 a631807682 requested a review from jinzhu April 24, 2022 03:50
@jinzhu jinzhu merged commit 6fa74f7 into go-gorm:master Apr 24, 2022
@a631807682 a631807682 deleted the fix_sercial_column branch April 24, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinzhu jinzhu Awaiting requested review from jinzhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@a631807682 @jinzhu