[CockroachDB] Fixing how it handle fields DEFAULT values and column types #143
Conversation
migrator.go
Outdated
| @@ -424,6 +439,8 @@ func (m Migrator) ColumnTypes(value interface{}) (columnTypes []gorm.ColumnType, | |||
|
|
|||
| if column.DefaultValueValue.Valid { | |||
| column.DefaultValueValue.String = regexp.MustCompile(`'(.*)'::[\w]+$`).ReplaceAllString(column.DefaultValueValue.String, "$1") | |||
| // cockroachdb, removing :::type | |||
| column.DefaultValueValue.String = regexp.MustCompile(`(.*):::[\w]+$`).ReplaceAllString(column.DefaultValueValue.String, "$1") | |||
There was a problem hiding this comment.
The following regexp can be merged with the above one?
There was a problem hiding this comment.
Changed it to '?(.*)\b'?:+[\w\s]+$, this should allow an optional QUOTE and matching any number of : between the field name and the field type.
Testing against the strings below will always get the word field:
'field'::character varying
'field':::character varying
field::character varying
field:::character varying
In cockroachdb, the default values returns something like `field:::TIMESTAMPZ`, and the validation here is only by the default value, without its type, this regex is required.
… cases: `'field'::character varying` `'field':::character varying` `field::character varying` `field:::character varying`
rwrz
force-pushed
the
rwrz-cockroachdb-default-fixes
branch
from
02a1ea8
to
68156b5
Compare
|
I've merged the regex, but forgot to remove another fix that I'm using here. This fix is to consider the "field type aliases" when checking if the column type has changed. |
| if fieldColumnType.DatabaseTypeName() != fileType.SQL { | ||
| isSameType = false | ||
| // if different, also check for aliases | ||
| aliases := m.GetTypeAliases(fieldColumnType.DatabaseTypeName()) |
There was a problem hiding this comment.
This fix is to consider the "field type aliases" when checking if the column type has changed.
What did this pull request do?
Currently, CockroachDB returns
:::int8together with their default values. We have a regex to remove it, that solves issues with PostgreSQL values, but it doesn't solve cockroachdb ones. So, I'm adding another regex to fix it.Also, column field types has aliases, and the migrator check them to decide if we need to ALTER a column or not. But the driver is not checking it, so, I'm adding this alias check as well.
User Case Description
You can test this this model:
It would trigger the ALTER COLUMN every time since
intreturnsint8and wasn't considering the alias tobigint. Also, it would have issues with thedefault:0, since it would check against0:::int8and0.