Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noticed a bug with embedded structs not being nil #6955

Open
stijndehaes opened this issue Apr 10, 2024 · 1 comment
Open

Noticed a bug with embedded structs not being nil #6955

stijndehaes opened this issue Apr 10, 2024 · 1 comment
Assignees
Labels

Comments

@stijndehaes
Copy link

stijndehaes commented Apr 10, 2024

GORM Playground Link

go-gorm/playground#714

Description

When adding a new type Address string and using that in an embedded struct, the embedded struct is not nil anymore when everything is empty.

I would love to contribute code to fix it but I find it a bit difficult to figure out all the reflection code 😅

I also wrote the same code here: https://github.com/stijndehaes/gorm/blob/bug/embedded-issue/tests/embedded_struct_test.go#L101

@github-actions github-actions bot added the type:missing reproduction steps missing reproduction steps label Apr 10, 2024
Copy link

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

@github-actions github-actions bot added status:stale type:with reproduction steps with reproduction steps and removed type:missing reproduction steps missing reproduction steps labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants