reafactor: add nil detection when sqldb return #6373
Merged
+5
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This pull request addresses a bug that caused a panic when connecting to the database using an incorrect DSN. The bug has already been fixed in this commit (c1ea730). However, to prevent potential future bugs, I have refactored the code to include null detection during type assertion.
User Case Description
gorm/gorm.go
Lines 374 to 387 in c1ea730
Before merging this PR (c1ea730),
connPool.(*sql.DB)
returnednil, nil
which had a negative impact on the called method.