Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag default:'null' always causes field migration #5953

Closed
Nomango opened this issue Dec 30, 2022 · 2 comments · Fixed by #5954
Closed

Tag default:'null' always causes field migration #5953

Nomango opened this issue Dec 30, 2022 · 2 comments · Fixed by #5954
Assignees
Labels

Comments

@Nomango
Copy link
Contributor

Nomango commented Dec 30, 2022

GORM Playground Link

No time to make it for now

Description

default:null and default:'null' are being treated the same when field migrating.

The reason is this line:

currentDefaultNotNull := field.HasDefaultValue && !strings.EqualFold(field.DefaultValue, "NULL")

field.DefaultValue is equal to null in both two cases.

Maybe it should change to

currentDefaultNotNull := field.HasDefaultValue && field.DefaultValueInterface != nil
@github-actions github-actions bot added the type:missing reproduction steps missing reproduction steps label Dec 30, 2022
@github-actions
Copy link

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

@github-actions
Copy link

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

jinzhu added a commit that referenced this issue Jan 1, 2023
…#5954)

* fix(migrator): Tag default:'null' always causes field migration #5953

* Update migrate_test.go

* Update migrate_test.go

* Update migrate_test.go

Co-authored-by: Jinzhu <wosmvp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants